Skip to content

Deprecate @pytest.mark.style(...). #20543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Deprecate @pytest.mark.style(...). #20543

merged 1 commit into from
Jun 29, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 28, 2021

@mpl.style.context can be used in the same way (and is just as
greppable), but doesn't require any support from the pytest machinery.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests say that you missed one usage, and that the deprecation is broken.

`@mpl.style.context` can be used in the same way (and is just as
greppable), but doesn't require any support from the pytest machinery.
@anntzer
Copy link
Contributor Author

anntzer commented Jun 29, 2021

Thanks, should be fixed now (crossed PR and all...).

@QuLogic QuLogic merged commit af17a9b into matplotlib:master Jun 29, 2021
@anntzer anntzer deleted the ums branch June 30, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants