Skip to content

FIX: PILLOW asarray bug #20565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2021
Merged

FIX: PILLOW asarray bug #20565

merged 1 commit into from
Jul 3, 2021

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Jul 2, 2021

PR Summary

Closes #20560 and fixes CI

I'm not sure if the other rawmodes should be fixed?

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@jklymak jklymak added this to the v3.4.3 milestone Jul 2, 2021
@timhoffm
Copy link
Member

timhoffm commented Jul 2, 2021

Maybe better to just avoid pillow 8.3.0 like here?

@jklymak
Copy link
Member Author

jklymak commented Jul 2, 2021

That's be fine w me. I don't have time for the next few hrs if someone else wanted to do it

Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer this solution, but perhaps @QuLogic should chime in wrt. packaging implications of #20566 as well?

@anntzer
Copy link
Contributor

anntzer commented Jul 3, 2021

I decided to merge this with my sole review in order to unbreak the build. Feel free to revert and exchange for #20566 if that ends up being preferred.

@anntzer anntzer merged commit 831a13c into matplotlib:master Jul 3, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jul 3, 2021
jklymak added a commit that referenced this pull request Jul 3, 2021
…565-on-v3.4.x

Backport PR #20565 on branch v3.4.x (FIX: PILLOW asarray bug)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_png is failing
3 participants