Skip to content

FIX: do not simplify path in LineCollection.get_segments #20584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2021
Merged

FIX: do not simplify path in LineCollection.get_segments #20584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/matplotlib/collections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1461,7 +1461,14 @@ def get_segments(self):
segments = []

for path in self._paths:
vertices = [vertex for vertex, _ in path.iter_segments()]
vertices = [
vertex
for vertex, _
# Never simplify here, we want to get the data-space values
# back and there in no way to know the "right" simplification
# threshold so never try.
in path.iter_segments(simplify=False)
]
vertices = np.asarray(vertices)
segments.append(vertices)

Expand Down
9 changes: 9 additions & 0 deletions lib/matplotlib/tests/test_collections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1039,3 +1039,12 @@ def test_quadmesh_cursor_data():
x, y = ax.transData.transform([-1, 101])
event = MouseEvent('motion_notify_event', fig.canvas, x, y)
assert qm.get_cursor_data(event) is None


def test_get_segments():
segments = np.tile(np.linspace(0, 1, 256), (2, 1)).T
lc = LineCollection([segments])

readback, = lc.get_segments()
# these should comeback un-changed!
assert np.all(segments == readback)