Skip to content

ENH colorbar.set_aspect #20588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Jul 7, 2021

PR Summary

Follow up to #20501

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

jklymak added 4 commits July 5, 2021 17:31
Previous overhaul packaged an inner and outer axes in a container
"ColorbarAxes" and tried to dispatch methods between them.

This overhaul takes the _much_ simpler approach of resizing the
image using a custom _axes_locator that a) calls any existing locator
b) or just uses the axes default position. The custom _axes_locator
then shrinks the axes in the appropriate direction to make room for
extend tri/rectangles.  As with the previous fix, the extend
tri/rectangles are drawn as patches in axes co-ordinates, rather than
pcolormesh in "data" co-ordinates.
@jklymak
Copy link
Member Author

jklymak commented Jan 4, 2022

Closing for #22103

@jklymak jklymak closed this Jan 4, 2022
@jklymak jklymak deleted the enh-set-aspect branch January 4, 2022 10:12
@QuLogic QuLogic removed this from the v3.6.0 milestone Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants