Hide some _SelectorWidget state internals.
#20601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, `eventrelease` is only set in the `release` handler, before calling the subclass's `_release`, and then immediately set to `None`. Within that time, it could be accessed from the `onselect` handler, but that's just the second argument passed to it anyway. So there's not really any use for `eventrelease` as a class attribute. The other two are similarly internal state tracking, and should not be modified externally.
jklymak
approved these changes
Jul 8, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
For example,
eventreleaseis only set in thereleasehandler, before calling the subclass's_release, and then immediately set toNone. Within that time, it could be accessed from theonselecthandler, but that's just the second argument passed to it anyway. So there's not really any use foreventreleaseas a class attribute.The other two are similarly internal state tracking, and should not be modified externally.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).