Skip to content

Deprecate unused LassoSelector event handlers. #20603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2021
Merged

Deprecate unused LassoSelector event handlers. #20603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/api/next_api_changes/deprecations/20603-AL.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
``LassoSelector.onpress`` and ``LassoSelector.onrelease``
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
... are deprecated (they are straight aliases for ``press`` and ``release``).
4 changes: 2 additions & 2 deletions lib/matplotlib/widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3061,13 +3061,15 @@ def __init__(self, ax, onselect=None, useblit=True, lineprops=None,
self.ax.add_line(self.line)
self.artists = [self.line]

@_api.deprecated("3.5", alternative="press")
def onpress(self, event):
self.press(event)

def _press(self, event):
self.verts = [self._get_data(event)]
self.line.set_visible(True)

@_api.deprecated("3.5", alternative="release")
def onrelease(self, event):
self.release(event)

Expand All @@ -3083,9 +3085,7 @@ def _onmove(self, event):
if self.verts is None:
return
self.verts.append(self._get_data(event))

self.line.set_data(list(zip(*self.verts)))

self.update()


Expand Down