Skip to content

Add HiDPI-related config for mathmpl #20659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 1, 2021
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jul 16, 2021

PR Summary

Namely, fontsize, and srcset. We need these for our new theme, which uses 11pt fonts instead of 10pt, and to match the gallery that provides 2x images.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

QuLogic added 3 commits July 16, 2021 20:58
And set it to 11 points, which matches the new theme.
And set it to include 2x in our docs, like with sphinx gallery.
@jklymak
Copy link
Member

jklymak commented Jul 20, 2021

Maybe not fair to ask you to do this, but I had no idea :mathmpl: existed, and I found no documentation as to what it supposed to do, in particular in the source file. Can this get some documentation?

@QuLogic
Copy link
Member Author

QuLogic commented Jul 22, 2021

i think it basically exists to create the examples in the docs for what mathtext does. Most external uses should probably use the Sphinx math extensions.

@anntzer
Copy link
Contributor

anntzer commented Jul 22, 2021

I think we should deprecate it for general use and move it to docs/sphinxext (perhaps not as part of this PR).

@QuLogic
Copy link
Member Author

QuLogic commented Jul 26, 2021

Should I bother documenting it if we're going to deprecate it?

@jklymak
Copy link
Member

jklymak commented Jul 26, 2021

I was suggesting just a couple lines at the top of the source, not formal docs..

@QuLogic
Copy link
Member Author

QuLogic commented Jul 28, 2021

I copied the docs out of plot_directive (though rather simplified).

@timhoffm timhoffm merged commit e291cdb into matplotlib:master Aug 1, 2021
@QuLogic QuLogic deleted the mathmpl-hidpi branch August 3, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants