Skip to content

Fix interaction between make_keyword_only and pyplot generation. #20686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2021
Merged

Fix interaction between make_keyword_only and pyplot generation. #20686

merged 1 commit into from
Jul 25, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 19, 2021

No independent test (because mocking boilerplate.py is too hard), but
note that the signature change on imshow works.

Closes #20684.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer anntzer added this to the v3.5.0 milestone Jul 19, 2021
@anntzer anntzer force-pushed the mkopyplot branch 2 times, most recently from 2271b49 to ff0a938 Compare July 20, 2021 00:02
@anntzer
Fix interaction between make_keyword_only and pyplot generation.
a8abb76 
No independent test (because mocking boilerplate.py is too hard), but
note that the signature change on imshow works.
jklymak
jklymak approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all a little bit magical to me, but seems correct, and it passes the tests...

@timhoffm timhoffm merged commit e09d088 into matplotlib:master Jul 25, 2021
@anntzer anntzer deleted the mkopyplot branch July 26, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

make_keyword_only doesn't work for pyplot-wrapped methods
3 participants
@anntzer @jklymak @timhoffm