Fix collection offsets #20717
Merged
Fix collection offsets #20717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d86465a to
c09ac03
Compare
tacaswell
approved these changes
Jul 23, 2021
|
This should be signed off on by @anntzer as I want to make sure this is not putting back something we removed recently. |
|
@tacaswell If you are specifically worried about #13696: no, this PR is not doing anything like that. |
QuLogic
reviewed
Jul 29, 2021
QuLogic
approved these changes
Aug 6, 2021
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Nov 5, 2021
This fixes a regression from matplotlib#20717 in networkx (Fixes matplotlib#21517), but we'll go forward with the change in a later release to give them time to fix it.
5 tasks
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Nov 6, 2021
This fixes a regression from matplotlib#20717 in networkx (Fixes matplotlib#21517), but we'll go forward with the change in a later release to give them time to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Made some suggested changes related to issue #20698.
Collection._uniform_offsetsandCollection._offsets, removed the former, kept the latter. Any function dependent on this variable was removed.Collection._offsetsNone, replaced with a check if offsets were non-zero where used.Collection.set_offset_transform().PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).I did add
Collection.set_offset_transform(), but this isn't really a new feature, since it can already be set during initialization, so I'm not sure if/how it should be documented. I can add a mention if necessary.Update 2021-07-23 09:47:
Artist.set_transform()toCollection.set_offset_transform()to be consistent.