Skip to content

DOC: Provide alternative to cbar.patch #20726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Conversation

larsoner
Copy link
Contributor

PR Summary

Closes #20635

@jklymak the places I was using cbar.patch, using cbar.ax was the correct solution (e.g., cbar.ax.set_facecolor instead of cbar.patch.set_facecolor). The message now reads:

The patch attribute was deprecated in Matplotlib 3.5 and will be removed two minor releases later. Use ax instead.

PR Checklist

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good if we think that folks are using patch and ax synonymously

@story645 story645 merged commit 63fad3b into matplotlib:master Jul 23, 2021
@jklymak jklymak added this to the v3.5.0 milestone Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Document patch deprecation
3 participants