Skip to content

Deprecate support for case-insensitive scales. #20753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Deprecate support for case-insensitive scales. #20753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions doc/api/next_api_changes/deprecations/20753-AL.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Case-insensitive scales
~~~~~~~~~~~~~~~~~~~~~~~
Previously, scales could be set case-insensitively (e.g. ``set_xscale("LoG")``).
This is deprecated; all builtin scales use lowercase names.
10 changes: 7 additions & 3 deletions lib/matplotlib/scale.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,9 +588,13 @@ def scale_factory(scale, axis, **kwargs):
scale : {%(names)s}
axis : `matplotlib.axis.Axis`
"""
scale = scale.lower()
_api.check_in_list(_scale_mapping, scale=scale)
return _scale_mapping[scale](axis, **kwargs)
if scale != scale.lower():
_api.warn_deprecated(
"3.5", message="Support for case-insensitive scales is deprecated "
"since %(since)s and support will be removed %(removal)s.")
scale = scale.lower()
scale_cls = _api.check_getitem(_scale_mapping, scale=scale)
return scale_cls(axis, **kwargs)


if scale_factory.__doc__:
Expand Down