Skip to content

Ensure all params are restored after reset_ticks. #20805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2021
Merged

Ensure all params are restored after reset_ticks. #20805

merged 1 commit into from
Aug 20, 2021

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 7, 2021

PR Summary

Currently, only label rotation was broken, but I set up the test to check everything.

Fixes #20791.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic
Ensure all params are restored after reset_ticks.
c304045 
Currently, only label rotation was broken, but I set up the test to
check everything.

Fixes matplotlib#20791.
@QuLogic QuLogic added this to the v3.5.0 milestone Aug 7, 2021
@tacaswell
Copy link
Member

Also seems related to #20219 ?

@QuLogic
Copy link
Member Author

QuLogic commented Aug 9, 2021

cla is not reset_ticks though. The latter is more of an internal convenience to make sure ticks are not stale by regenerating them. It is not supposed to change settings.

timhoffm
timhoffm approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As surprising as the fix is, this seems to be the correct solution to the issue.

Semi-OT: Should reset_ticks() be public? Clearing the tick list but keeping tick_params seems more like an internal helper.

@tacaswell tacaswell merged commit c423658 into matplotlib:master Aug 20, 2021
@QuLogic QuLogic deleted the fix-tick-reset branch August 20, 2021 19:51
@timhoffm timhoffm mentioned this pull request Apr 17, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: ticks axis labels
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

[Bug]: spines and ticklabels
3 participants
@QuLogic @tacaswell @timhoffm