Skip to content

Allow SubFigure legends #20859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2021
Merged

Allow SubFigure legends #20859

merged 2 commits into from
Aug 20, 2021

Conversation

tomneep
Copy link
Contributor

@tomneep tomneep commented Aug 19, 2021 •
edited
Loading

PR Summary

As reported in #20723, this changes the isinstance check in Legend to check against FigureBase instead of Figure

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • N/A: API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@jklymak
Copy link
Member

jklymak commented Aug 19, 2021

Great! However can this get a subfigure test to make sure it works?

@tomneep
Copy link
Contributor Author

tomneep commented Aug 20, 2021

I've added a test

@anntzer anntzer added this to the v3.5.0 milestone Aug 20, 2021
@anntzer
Copy link
Contributor

anntzer commented Aug 20, 2021

seems safe enough to milestone to 3.5.

@anntzer anntzer merged commit 98306f9 into matplotlib:master Aug 20, 2021
@tomneep tomneep deleted the subfigure-legend branch August 20, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkseppan jkseppan jkseppan approved these changes

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: legend
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

Adding a legend to a SubFigure doesn't work
5 participants
@tomneep @jklymak @anntzer @jkseppan @timhoffm