Skip to content

Ignore errors trying to delete make_release_tree. #20869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2021

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 21, 2021

PR Summary

Which apparently happens in Fedora's automated build requirement generator.

PR Checklist

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Which apparently happens in Fedora's automated build requirement
generator.
@QuLogic QuLogic added the Build label Aug 21, 2021
@QuLogic QuLogic added this to the v3.5.0 milestone Aug 21, 2021
@timhoffm
Copy link
Member

May be a temporary fix. Note however that distutils will be deprecated in 3.10 https://www.python.org/dev/peps/pep-0632/, so we need a different approach anyway.

@QuLogic
Copy link
Member Author

QuLogic commented Aug 21, 2021

Yes, hence #20437, but setuptools does not yet completely replace distutils pypa/setuptools#2698

We may have to go some other way entirely, maybe more declarative or some such.

Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, this fixes it.

@jkseppan jkseppan merged commit ca275dc into matplotlib:master Aug 21, 2021
@QuLogic QuLogic deleted the fix-setup branch August 23, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants