Make pywin32 optional in Ctrl+C Qt test. #20883
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
0fcd698 to
852a63b
Compare
tacaswell
approved these changes
Aug 24, 2021
|
We did not catch this because we do not test Qt on windows or codecov is behaving a bit wonky. I'm going to try pushing a commit adding pyqt to appveyor. |
|
|
|
If this fails on appveyor, I am 👍🏻 on @QuLogic force-pushing my commit out of existence and self-merging. |
tacaswell
approved these changes
Aug 24, 2021
9de2c03 to
852a63b
Compare
4 tasks
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Aug 26, 2021
As it was only needed for the sigint tests. (matplotlib#20883)
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Aug 31, 2021
As it was only needed for the sigint tests. (matplotlib#20883)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
From https://github.com/matplotlib/matplotlib/pull/13306/files/c3772ae037c5a2c7614013a9c36954675c5d9de0#diff-ee95644f45380b6c0cf91171c8c048ed673628bd67f14876ddd60abe0a3e0371
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).