Skip to content

Fix broken QApplication init in a test. #20885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2021
Merged

Fix broken QApplication init in a test. #20885

merged 1 commit into from
Aug 25, 2021

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 24, 2021

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic QuLogic added this to the v3.5.0 milestone Aug 24, 2021
anntzer
anntzer approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postci

@QuLogic
Copy link
Member Author

QuLogic commented Aug 24, 2021

Hmm, actually, this still crashes for me if run by itself. I think it just worked because something else ran before it.

@QuLogic QuLogic marked this pull request as draft August 24, 2021 09:51
@tacaswell
Copy link
Member

Shouldn't this be using our "get or make the qt application" helper from qt_backend?

@QuLogic QuLogic marked this pull request as ready for review August 24, 2021 20:57
@QuLogic
Copy link
Member Author

QuLogic commented Aug 24, 2021

Yea, that works; now I can directly run pytest lib/matplotlib/tests/test_backend_qt.py::test_form_widget_get_with_datetime_and_date_fields without it crashing.

@timhoffm timhoffm merged commit 58cd97b into matplotlib:master Aug 25, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 25, 2021
@timhoffm @meeseeksmachine
Backport PR matplotlib#20885: Fix broken QApplication init in a test.
d6236d9
@meeseeksmachine meeseeksmachine mentioned this pull request Aug 25, 2021
Merged
@QuLogic QuLogic deleted the fix-test-qt-app branch August 25, 2021 19:39
QuLogic added a commit that referenced this pull request Aug 25, 2021
@QuLogic
Merge pull request #20899 from meeseeksmachine/auto-backport-of-pr-20…
623605c 
…885-on-v3.5.x

Backport PR #20885 on branch v3.5.x (Fix broken QApplication init in a test.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@QuLogic @tacaswell @anntzer @timhoffm @dstansby