Move sigint tests into subprocesses #20907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Strange, it fails when the entire test suite is run, but not when running only the one test (or even just the one file). |
|
Ah, it's probably because |
6eab1f1 to
f2740fd
Compare
112668e to
a40759c
Compare
20c764d to
c2a5cb2
Compare
This prevents them accidentally breaking the test runner itself, depending on platform.
c2a5cb2 to
9d13e7d
Compare
tacaswell
approved these changes
Sep 22, 2021
jklymak
reviewed
Sep 23, 2021
| qt_core.QTimer.singleShot(100, fire_sigint) | ||
| def custom_signal_handler(signum, frame): | ||
| timer.start() | ||
| signal.signal(signal.SIGUSR1, custom_signal_handler) |
There was a problem hiding this comment.
There is a whole bunch of code here that is not being run. Is that on purpose/it will be run at a later date?
There was a problem hiding this comment.
Everything in *_impl functions are run in a subprocess which coverage doesn't see.
anntzer
reviewed
Sep 30, 2021
anntzer
approved these changes
Sep 30, 2021
timhoffm
approved these changes
Sep 30, 2021
jklymak
approved these changes
Oct 1, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 1, 2021
timhoffm
added a commit
that referenced
this pull request
Oct 1, 2021
…907-on-v3.5.x Backport PR #20907 on branch v3.5.x (Move sigint tests into subprocesses)
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 12, 2021
Move sigint tests into subprocesses
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Move sigint tests into subprocesses
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This prevents them accidentally breaking the test runner itself, depending on platform. Also, enable Qt tests on AppVeyor. A followup to #20883.
I haven't convertedtest_fig_sigint_overrideyet, as I want to see if this works on Windows.test_fig_sigint_overridedoesn't actually fire any signals, but I modified it to ensure it doesn't leave broken global state.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).