Move installing FAQ to installing page. #20917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People with install problems will primarily look at the install page,
not the general FAQ page.
Question: Should we move the page in the file structure as well?
Con: External pages linking the FAQ will be broken. I wouldn't worry
too much about this. Who links install FAQs anyway? And I trust
that even with a broken Link people will look at Installing.
Pro: The file structure corresponds to the toc structure.
|
hi @timhoffm can I work on it? |
|
@rishawsingh Thanks for your interest in contributing. This is a pull request, i.e. the work is already done in here. There's nothing more to do other than approve, which has to be done by a core contributor. You are welcome to pick another issue. Check the "good first issue" tag. |
story645
approved these changes
Aug 27, 2021
|
I would argue not, unless there is reason for controversy, or by structural you mean a large reorg. Changing documentation doesn't break anyone and we can always revert if someone strongly objects. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 27, 2021
QuLogic
added a commit
that referenced
this pull request
Aug 27, 2021
…917-on-v3.5.x Backport PR #20917 on branch v3.5.x (Move installing FAQ to installing page.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People with install problems will primarily look at the install page,
not the general FAQ page.
Question: Should we move the page in the file structure as well?
Con: External pages linking the FAQ will be broken. I wouldn't worry
too much about this. Who links install FAQs anyway? And I trust
that even with a broken Link people will look at Installing.
Pro: The file structure corresponds to the toc structure.