Skip to content

Fix cubic curve code in Path.__doc__ #20920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

dpoznik
Copy link
Contributor

@dpoznik dpoznik commented Aug 27, 2021

PR Summary

This fixes a small typo in Path.__doc__. The code for a cubic curve was referred to as CURVE3 rather than CURVE4.

PR Checklist

  • [N/A] Has pytest style unit tests (and pytest passes).
  • [N/A] Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@timhoffm timhoffm added this to the v3.5.0 milestone Aug 27, 2021
@timhoffm timhoffm merged commit 7b1b6f9 into matplotlib:master Aug 27, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 27, 2021
@timhoffm
Copy link
Member

Thanks @dpoznik!

@dpoznik dpoznik deleted the fix-Path-doc-typo branch August 27, 2021 15:21
@dpoznik
Copy link
Contributor Author

dpoznik commented Aug 27, 2021

Thanks @dpoznik!

Happy to help. Thanks for the quick review @timhoffm!

QuLogic added a commit that referenced this pull request Aug 27, 2021
…920-on-v3.5.x

Backport PR #20920 on branch v3.5.x (Fix cubic curve code in `Path.__doc__`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants