Make warning for no-handles legend more explicit. #20956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may be slightly better to only emit the longer message if there were actually handles that got ignored because of the leading underscore, but that's actually a bit annoying to check (or requires some refactoring of _get_legend_handles_labels).
QuLogic
approved these changes
Aug 31, 2021
timhoffm
approved these changes
Sep 1, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 1, 2021
QuLogic
added a commit
that referenced
this pull request
Sep 1, 2021
…956-on-v3.5.x Backport PR #20956 on branch v3.5.x (Make warning for no-handles legend more explicit.)
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Make warning for no-handles legend more explicit.
ericpre
pushed a commit
to ericpre/matplotlib
that referenced
this pull request
Oct 20, 2021
Make warning for no-handles legend more explicit.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be slightly better to only emit the longer message if there were
actually handles that got ignored because of the leading underscore, but
that's actually a bit annoying to check (or requires some refactoring of
_get_legend_handles_labels).
See #5200 (comment).
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).