Skip to content

Small cleanups to math_to_image. #20961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Small cleanups to math_to_image. #20961

merged 1 commit into from
Sep 1, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 1, 2021

  • parse() already normalizes prop=None to prop=FontProperties().
  • We don't need to explicitly attach a canvas to a plain Figure() before
    calling savefig() anymore; FigureCanvasBase is always attached and
    handles the dispatching to the correct concrete canvas class.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

- parse() already normalizes prop=None to prop=FontProperties().
- We don't need to explicitly attach a canvas to a plain Figure() before
  calling savefig() anymore; FigureCanvasBase is always attached and
  handles the dispatching to the correct concrete canvas class.
@dstansby dstansby merged commit 0a9007c into matplotlib:master Sep 1, 2021
@anntzer anntzer deleted the mti branch September 1, 2021 23:05
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
Small cleanups to math_to_image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants