Skip to content

BUG: Fix f_back is None handling #20965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2021
Merged

BUG: Fix f_back is None handling #20965

merged 1 commit into from
Sep 1, 2021

Conversation

larsoner
Copy link
Contributor

@larsoner larsoner commented Sep 1, 2021

PR Summary

PR Checklist

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

On anything after #19255, when resizing some plots (on PyQt5 5.15.4) I get:

>>> Traceback (most recent call last):
  File "/home/larsoner/python/matplotlib/lib/matplotlib/backends/backend_qt.py", line 336, in resizeEvent
    if frame.f_code is frame.f_back.f_code:  # Prevent PyQt6 recursion.
AttributeError: 'NoneType' object has no attribute 'f_code'

This PR fixes this problem using getatttr. I'm not sure how to make a good unit-test for this...

@tacaswell tacaswell added this to the v3.5.0 milestone Sep 1, 2021
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Sep 1, 2021
@QuLogic QuLogic merged commit 2e31b07 into matplotlib:master Sep 1, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 1, 2021
@larsoner larsoner deleted the fback branch September 1, 2021 20:15
dstansby added a commit that referenced this pull request Sep 1, 2021
…965-on-v3.5.x

Backport PR #20965 on branch v3.5.x (BUG: Fix f_back is None handling)
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
BUG: Fix f_back is None handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants