Rename symbol_name to glyph_name where appropriate. #20974
Merged
+21
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When referring to a font glyph, "glyph name" is standard terminology (e.g. FT_Get_Glyph_Name or Adobe docs); additionally there is a separate concept of "symbol_name" used by the mathtext parser which has a different meaning (`\foo` commands referring to TeX symbol names), so let's not confuse them. symbol_name is kept in the mathtext SimpleNamespaces for backcompat (changing the SimpleNamespace to a proper class with a property handling the deprecation is not worth the work).
timhoffm
approved these changes
Sep 2, 2021
QuLogic
approved these changes
Sep 2, 2021
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Rename symbol_name to glyph_name where appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When referring to a font glyph, "glyph name" is standard terminology
(e.g. FT_Get_Glyph_Name or Adobe docs); additionally there is a separate
concept of "symbol_name" used by the mathtext parser which has a
different meaning (
\foocommands referring to TeX symbol names), solet's not confuse them.
symbol_name is kept in the mathtext SimpleNamespaces for backcompat
(changing the SimpleNamespace to a proper class with a property handling
the deprecation is not worth the work).
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).