-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Rotate errorbar caps in polar plots #21006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
370b4a2
to
dce4026
Compare
dce4026
to
c053448
Compare
To decrease the image diff I think it's good enough just add a separate test just checking png (as we don't expect to have anything that's backend-dependent here) and leave test_errorbar as it was initially? Otherwise looks good to me. |
👍 - I thought it was better to modify or add to an existing image than create a new one, but I guess that's not the case? |
Ah right, I get your point about just adding a new .png test instead of changing all three images 👍 |
c053448
to
ea337ef
Compare
Thanks. |
Hi, would you kindly consider changes in #20914 ? It will allow you specify transform during construction and not by overwriting _transform afterwards. However, it is not reviewed and I don’t know if it is a good practice to chain PRs. |
Thanks for bringing that up - I've had a look at that PR, and will re-base this one if/when #20914 is merged. |
I'll mark draft until #20914 gets in... |
This PR is affected by a re-writing of our history to remove a large number of accidentally committed files see discourse for details. To recover this PR it will need be rebased onto the new default branch (main). There are several ways to accomplish this, but we recommend (assuming that you call the matplotlib/matplotlib remote git remote update
git checkout main
git merge --ff-only upstream/main
git checkout YOUR_BRANCH
git rebase --onto=main upstream/old_master
# git rebase -i main # if you prefer
git push --force-with-lease # assuming you are tracking your branch If you do not feel comfortable doing this or need any help please reach out to any of the Matplotlib developers. We can either help you with the process or do it for you. Thank you for your contributions to Matplotlib and sorry for the inconvenience. |
ea337ef
to
e60d080
Compare
I'm going to close this, as I'm not enjoying trying to get my head round the logic in |
I take the liberty to reopen this and mark it as orphaned. May increase the chance of someone picking it up. |
I'm going to close this in favour of #23592 |
PR Summary
Fixes #441 (what prize do I get for a three figure issue 😄?). Here's an example:

PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).