FIX: Don't subslice lines if non-standard transform #21017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ff497c to
7c3147b
Compare
anntzer
approved these changes
Sep 8, 2021
|
No I'll add a test. Just was interrupted. |
e1ca3e7 to
391cb76
Compare
|
New commit adds a test that fails on master with all the data sliced out, and is fine with this PR. |
391cb76 to
eba5cdc
Compare
dstansby
approved these changes
Sep 9, 2021
timhoffm
approved these changes
Sep 9, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 9, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 9, 2021
QuLogic
added a commit
that referenced
this pull request
Sep 9, 2021
…017-on-v3.5.x Backport PR #21017 on branch v3.5.x (FIX: Don't subslice lines if non-standard transform)
QuLogic
added a commit
that referenced
this pull request
Sep 10, 2021
…017-on-v3.4.x Backport PR #21017 on branch v3.4.x (FIX: Don't subslice lines if non-standard transform)
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
FIX: Don't subslice lines if non-standard transform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Line2Dobjects are "sub sliced" if they are well-ordered, and their view window is smaller than the actual data extents. However, if someone applies a transform, in particular a lateral translation, then the data all ends up out of view. This adds a check to only apply the subslice algorithm if the transform isax.transData.Closes #21008
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).