Skip to content

Inline ToolManager._trigger_tool to its sole call site. #21023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Inline ToolManager._trigger_tool to its sole call site. #21023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions lib/matplotlib/backend_managers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,23 +376,15 @@ def trigger_tool(self, name, sender=None, canvasevent=None, data=None):
if sender is None:
sender = self

self._trigger_tool(name, sender, canvasevent, data)
if isinstance(tool, tools.ToolToggleBase):
self._handle_toggle(tool, sender, canvasevent, data)

tool.trigger(sender, canvasevent, data) # Actually trigger Tool.

s = 'tool_trigger_%s' % name
event = ToolTriggerEvent(s, sender, tool, canvasevent, data)
self._callbacks.process(s, event)

def _trigger_tool(self, name, sender=None, canvasevent=None, data=None):
"""Actually trigger a tool."""
tool = self.get_tool(name)

if isinstance(tool, tools.ToolToggleBase):
self._handle_toggle(tool, sender, canvasevent, data)

# Important!!!
# This is where the Tool object gets triggered
tool.trigger(sender, canvasevent, data)

def _key_press(self, event):
if event.key is None or self.keypresslock.locked():
return
Expand Down