Place 3D contourf patches between levels #21026
Merged
+79
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88106bb to
f29b5be
Compare
timhoffm
approved these changes
Sep 9, 2021
|
After this change (which seems otherwise correct), the topmost contour surface ends up above the axis zmax (this can be checked e.g. running |
bef1f2c to
0809531
Compare
|
I've fixed the limits - it's not a very elegant solution (having to manually calculate the limits, see comments I left in the code), but it works... |
anntzer
reviewed
Sep 24, 2021
|
Looks good to me, except for perhaps the style thing above (and modulo CI). |
0809531 to
876022e
Compare
QuLogic
reviewed
Sep 25, 2021
timhoffm
reviewed
Sep 26, 2021
8351cf1 to
11493d8
Compare
11493d8 to
44e04d8
Compare
timhoffm
approved these changes
Sep 27, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 27, 2021
QuLogic
added a commit
that referenced
this pull request
Sep 27, 2021
…026-on-v3.5.x Backport PR #21026 on branch v3.5.x (Place 3D contourf patches between levels)
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 12, 2021
Place 3D contourf patches between levels
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Place 3D contourf patches between levels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When doing a
contourf, each polygon represents data between two levels. When setting a z-value for these polygons in 3D, previously the lower level would be chosen. This PR changes that to set the z-value to be the midpoint of the two levels. Also adds support for extensions by linearly interpolating the midpoints of the first and last levels.Fixes #21016
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).