Skip to content

Deprecate many single-use rc validators. #21054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 12, 2021

They can all easily be defined inline at the place of use.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer anntzer added this to the v3.6.0 milestone Sep 12, 2021
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's defer this to after the 3.5 release. I intend to start a general discussion on configuration handling for 3.6, an this deprecation may or may not match with its result.

I'll block to prevent accidential merging.

@anntzer
Copy link
Contributor Author

anntzer commented Sep 14, 2021

Sure, no worries.

@jklymak jklymak marked this pull request as draft September 14, 2021 11:32
@tacaswell
Copy link
Member

This PR is affected by a re-writing of our history to remove a large number of accidentally committed files see discourse for details.

To recover this PR it will need be rebased onto the new default branch (main). There are several ways to accomplish this, but we recommend (assuming that you call the matplotlib/matplotlib remote "upstream"

git remote update
git checkout main
git merge --ff-only upstream/main
git checkout YOUR_BRANCH
git rebase --onto=main upstream/old_master
# git rebase -i main # if you prefer
git push --force-with-lease   # assuming you are tracking your branch

If you do not feel comfortable doing this or need any help please reach out to any of the Matplotlib developers. We can either help you with the process or do it for you.

Thank you for your contributions to Matplotlib and sorry for the inconvenience.

They can all easily be defined inline at the place of use.
@anntzer anntzer marked this pull request as ready for review June 6, 2023 17:00
@anntzer
Copy link
Contributor Author

anntzer commented Jun 6, 2023

@timhoffm Do you still want to block this, even though that there hasn't been major reworking of rcparams since your last comment? (I'm totally OK if you do, in which case we should probably just close this.)

@timhoffm
Copy link
Member

timhoffm commented Jun 7, 2023

I would still put this on hold. The first step in rcParams redesign is #25617. More will come after that.

@anntzer
Copy link
Contributor Author

anntzer commented Jun 7, 2023

Let's just close this then.

@anntzer anntzer closed this Jun 7, 2023
@timhoffm
Copy link
Member

timhoffm commented Jun 8, 2023

Note: #26088 now uses the validators as is. But we may change that later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants