Support marker="none" to mean "no marker". #21055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Sep 12, 2021
Comment on lines
3
to
4
| ... to mean "no-marker", consistently with other APIs which support the | ||
| lowercase version. |
There was a problem hiding this comment.
Suggested change
| ... to mean "no-marker", consistently with other APIs which support the | |
| lowercase version. | |
| ... to mean *no-marker*, consistently with other APIs which support the | |
| lowercase version. Using 'none' is recommended over using 'None'. |
jklymak
reviewed
Sep 13, 2021
lib/matplotlib/markers.py
Outdated
| @@ -45,7 +45,8 @@ | |||
| ``9`` (``CARETRIGHTBASE``) |m34| caretright (centered at base) | |||
| ``10`` (``CARETUPBASE``) |m35| caretup (centered at base) | |||
| ``11`` (``CARETDOWNBASE``) |m36| caretdown (centered at base) | |||
| ``"None"``, ``" "`` or ``""`` nothing | |||
| ``"None"`` or ``"None"`` nothing | |||
There was a problem hiding this comment.
Did you mean:
Suggested change
| ``"None"`` or ``"None"`` nothing | |
| ``"none"`` or ``"None"`` nothing |
As for other APIs, this is less likely to be confused with the None object.
jklymak
approved these changes
Sep 14, 2021
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Support marker="none" to mean "no marker".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As for other APIs (#19300), this is less likely to be confused with the None
object.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).