Skip to content

Remove most visible dependencies on distutils. #21061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 13, 2021

They are instead replaced by slightly roundabout ways to get hold of the
same objects (CompilerError, CCompiler).

Only distutils.sysconfig remains; we should investigate whether the
stdlib's sysconfig is a satisfactory replacement for it.

See #21057.

(Even if we waited for setuptools to correctly export these names or provide
replacement APIs, it would be slightly awkward to immediately require a very
new setuptools version for build.)

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

They are instead replaced by slightly roundabout ways to get hold of the
same objects (CompilerError, CCompiler).

Only distutils.sysconfig remains; we should investigate whether the
stdlib's sysconfig is a satisfactory replacement for it.
@anntzer anntzer added the Build label Sep 13, 2021
@timhoffm timhoffm added this to the v3.5.0 milestone Sep 13, 2021
@QuLogic
Copy link
Member

QuLogic commented Sep 13, 2021

Only distutils.sysconfig remains; we should investigate whether the
stdlib's sysconfig is a satisfactory replacement for it.

It should be; I thought I PR'd that already even...

@QuLogic QuLogic merged commit 0e14162 into matplotlib:master Sep 14, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 14, 2021
QuLogic added a commit that referenced this pull request Sep 14, 2021
…061-on-v3.5.x

Backport PR #21061 on branch v3.5.x (Remove most visible dependencies on distutils.)
@anntzer anntzer deleted the ud branch September 14, 2021 07:07
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
Remove most visible dependencies on distutils.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants