Break links between twinned axes when removing #21076
Merged
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
Sep 14, 2021
timhoffm
approved these changes
Sep 14, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 14, 2021
|
and @dstansby may have just set a land-speed record for 2 reviews + merge! |
timhoffm
added a commit
that referenced
this pull request
Sep 14, 2021
…076-on-v3.5.x Backport PR #21076 on branch v3.5.x (Break links between twinned axes when removing)
tacaswell
added a commit
that referenced
this pull request
Oct 20, 2021
FIX: Break links between twinned axes when removing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #18925. This doesn't reset the original Axes' locator/formatter which requires a much larger change, but at least calling
remove()doesn't error with this PR.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).