Capitalization fixes in example section titles. #21086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Sep 16, 2021
There was a problem hiding this comment.
I don't think this is an improvement.
Mixing in some verbatim titles in the toc looks odd:
https://63548-1385122-gh.circle-artifacts.com/0/doc/build/html/users/index.html
Even more, this leads to completely different title formatting in the gallery itself:
https://63548-1385122-gh.circle-artifacts.com/0/doc/build/html/gallery/index.html#pyplot
I'd rather leave these unformatted here.
|
I removed the double backquotes (but kept the uncapitalization, and the underscore in axes_grid1), perhaps that'll look better? |
|
@anntzer forgot to push? |
|
oops, indeed. |
timhoffm
approved these changes
Sep 19, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 19, 2021
timhoffm
added a commit
that referenced
this pull request
Sep 19, 2021
…086-on-v3.5.x Backport PR #21086 on branch v3.5.x (Capitalization fixes in example section titles.)
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 12, 2021
Capitalization fixes in example section titles.
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Capitalization fixes in example section titles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
(See https://matplotlib.org/devdocs/users/index.html for how it currently looks.)
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).