-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add contour and tricontour plots to plot types #21114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think there is benefit to not cluttering this list up too much, versus an attempt to be comprehensive. I'm not sure separating contour and contourf is worth the extra entry(s)? |
I like it seperate since I think a goal of this is making explicit implicit assumptions about data structure, in this case that it's unstructured coordinates. But kinda think this should go under the imshow/array section. |
tricontour/f already had its own entry. The question here is whether we need separate entries for each of contour and contourf and tricontour and tricontourf. |
Reading through the docs, I'm very confused about when to use the regular version vs. the f one, & that's not explained when collapsed into one example either. (I never remember that f stands for filled). I think separating the two here makes that clear, which I think is a good idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should levels be set w/ rest of data?
Again, I don't think the goal here is to be comprehensive, but rather to give folks enough knowledge to know what to search for. In this case both |
When I click through, the first sentence I see on both methods is
which I think is because of #17742? And for me it's not about comprehensive, it's that contour and contourf have different use cases* and collapsing them like this makes that unclear. Eta: what I mean by use cases isn't actually use cases, it's that the contour is visually encoding a line, contourf is visually encoding an area |
Sure, if folks think they are distinct enough, they should get separate entries. I don't think they are, but that is just my opinion. |
ae5f936
to
dba6015
Compare
I think they are distinct enough visually. IMHO the main use case of "Plot types" is to look at the plots and decide which visual representation you want. And for that lines and filled areas are quite different. That they encode the same type of information is secondary. It's somewhat analogous to |
Note: I had to rename: examples/frontpage/contour.py → examples/frontpage/contour_frontpage.py Apparently, Sphinx-gallery doesn't like the same name in different galleries:
While the above renaming breaks someone external linking the front page coutour example, I anticipate that that'd be avery rare case and I willing to take that so that we have more consistent names in the |
Needs a rebate needs a rebase cause of #21123 |
dba6015
to
ec5d889
Compare
ec5d889
to
64e7b2e
Compare
…114-on-v3.5.x Backport PR #21114 on branch v3.5.x (Add contour and tricontour plots to plot types)
Add contour and tricontour plots to plot types
Add contour and tricontour plots to plot types
No description provided.