Skip to content

Fix DATA_PARAMETER_PLACEHOLDER interpolation for quiver&contour{,f}. #21141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 20, 2021

The docstring must be set (which we do using docstring.dedent_interpd)
before the decoration with _preprocess_data().

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is the pattern we use most other places...

The docstring must be set (which we do using docstring.dedent_interpd)
before the decoration with _preprocess_data().

While we're at it, replace kw by kwargs in quiver/barbs.
@anntzer
Copy link
Contributor Author

anntzer commented Sep 21, 2021

While I was at it, I also replaced kw by kwargs in quiver and barbs (doing so in a separate PR would have resulted in a merge conflict).

@timhoffm timhoffm added this to the v3.5.0 milestone Sep 22, 2021
@timhoffm timhoffm merged commit 1daed58 into matplotlib:master Sep 22, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 22, 2021
@anntzer anntzer deleted the cqd branch September 22, 2021 11:53
jklymak added a commit that referenced this pull request Sep 22, 2021
…141-on-v3.5.x

Backport PR #21141 on branch v3.5.x (Fix DATA_PARAMETER_PLACEHOLDER interpolation for quiver&contour{,f}.)
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Oct 12, 2021
Fix DATA_PARAMETER_PLACEHOLDER interpolation for quiver&contour{,f}.
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
Fix DATA_PARAMETER_PLACEHOLDER interpolation for quiver&contour{,f}.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants