Skip to content

Fix clim handling for pcolor{,mesh}. #21146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 21, 2021

Previously, clim would be implicitly handled as part of kwargs, and
therefore get overwritten when the norm is set. The solution is to set
the norm first.

Closes #4132.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Previously, clim would be implicitly handled as part of kwargs, and
therefore get overwritten when the norm is set.  The solution is to set
the norm first.
@timhoffm timhoffm added this to the v3.5.0 milestone Sep 22, 2021
@timhoffm timhoffm merged commit c09cd9a into matplotlib:master Sep 22, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 22, 2021
@anntzer anntzer deleted the clim branch September 22, 2021 11:53
jklymak added a commit that referenced this pull request Sep 22, 2021
…146-on-v3.5.x

Backport PR #21146 on branch v3.5.x (Fix clim handling for pcolor{,mesh}.)
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Oct 12, 2021
Fix clim handling for pcolor{,mesh}.
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
Fix clim handling for pcolor{,mesh}.
@anntzer anntzer mentioned this pull request Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support clim kwarg in pcolor-type plots
3 participants