Deprecate mlab.stride_windows. #21190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functionality is directly provided by numpy>=1.20 (it will be a while before we can rely on that version of numpy, but we can still deprecate stride_windows as public API in the meantime, as we don't want to encourage users to rely on mlab for that).
story645
approved these changes
Sep 27, 2021
dstansby
approved these changes
Sep 27, 2021
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 12, 2021
Deprecate mlab.stride_windows.
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Deprecate mlab.stride_windows.
|
So the NumPy version actually OOMs in while patching to the original still passes the test. That being said, I'm hoping I can drop 32-bit support soon, and not have to worry about this, but maybe this new method is using more memory than it should? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality is directly provided by numpy>=1.20 (it will be a
while before we can rely on that version of numpy, but we can still
deprecate stride_windows as public API in the meantime, as we don't want
to encourage users to rely on mlab for that).
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).