Skip to content

Discourage making style changes to extern/. #21192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 27, 2021

PR Summary

cf #21175, and a few older PRs which were touching the same code.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@dstansby dstansby added this to the v3.5.0 milestone Sep 27, 2021
@dstansby dstansby merged commit 060d5c8 into matplotlib:master Sep 27, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 27, 2021
@anntzer anntzer deleted the ext branch September 27, 2021 13:29
timhoffm added a commit that referenced this pull request Sep 27, 2021
…192-on-v3.5.x

Backport PR #21192 on branch v3.5.x (Discourage making style changes to extern/.)
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Oct 12, 2021
Discourage making style changes to extern/.
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
Discourage making style changes to extern/.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants