Skip to content

Backport PR #21192 on branch v3.5.x (Discourage making style changes to extern/.) #21194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Backport PR #21192 on branch v3.5.x (Discourage making style changes to extern/.) #21194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/devel/contributing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,11 @@ C/C++ extensions
docstrings, and the Numpydoc format is well understood in the
scientific Python community.

* C/C++ code in the :file:`extern/` directory is vendored, and should be kept
close to upstream whenever possible. It can be modified to fix bugs or
implement new features only if the required changes cannot be made elsewhere
in the codebase. In particular, avoid making style fixes to it.

.. _keyword-argument-processing:

Keyword argument processing
Expand Down