Shorten PdfPages FAQ entry. #21229
Merged
Shorten PdfPages FAQ entry. #21229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original wording was inaccurate as both the pdf and pgf backends provide this functionality. I tried fixing that, but duplicating all links to both backends seemed unwieldy; additionally the "narrative" version of the FAQ reads worse (we should just encourage `pp.savefig()` instead of explaining that `plt.savefig()` needs workarounds, and also prefer `with PdfPages(...) as pp:`). Given that the docstring of both classes have examples, I just got rid of most of the FAQ entry instead (see also the next FAQ entries, which also have no code).
timhoffm
approved these changes
Sep 30, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 30, 2021
timhoffm
added a commit
that referenced
this pull request
Sep 30, 2021
…229-on-v3.5.x Backport PR #21229 on branch v3.5.x (Shorten PdfPages FAQ entry.)
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 12, 2021
Shorten PdfPages FAQ entry.
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Shorten PdfPages FAQ entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original wording was inaccurate as both the pdf and pgf backends
provide this functionality. I tried fixing that, but duplicating all
links to both backends seemed unwieldy; additionally the "narrative"
version of the FAQ reads worse (we should just encourage
pp.savefig()instead of explaining that
plt.savefig()needs workarounds, and alsoprefer
with PdfPages(...) as pp:). Given that the docstring of bothclasses have examples, I just got rid of most of the FAQ entry instead
(see also the next FAQ entries, which also have no code).
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).