Ensure internal FreeType matches Python compile #21263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, mixed compilers might break things when compiled together into the extension. Fixes matplotlib#21202
This should fix 32-bit compiles on a 64-bit system, as in matplotlib#18113, but I could never get a working 32-bit Python to test.
tacaswell
approved these changes
Oct 2, 2021
|
Will this fix the recently reported issues with freeBSD + clang? |
jklymak
approved these changes
Oct 4, 2021
|
Feel free to merge if @tacaswell question is addressed... |
|
Yes, see commit messages. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 4, 2021
QuLogic
added a commit
that referenced
this pull request
Oct 6, 2021
…263-on-v3.5.x Backport PR #21263 on branch v3.5.x (Ensure internal FreeType matches Python compile)
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 12, 2021
Ensure internal FreeType matches Python compile
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Ensure internal FreeType matches Python compile
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Pass along a few options to ensure that FreeType doesn't end up with a mixed compiler or bit-ness compared to the rest of the compiled
ft2fontextension.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).