Skip to content

Fix freetype wheel building #21279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Fix freetype wheel building #21279

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36a6b3c
Ensure *full* compiler config is passed to FreeType
QuLogic Oct 4, 2021
81730f7
Fix FreeType build PyPy
QuLogic Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions setupext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,22 +605,27 @@ def do_custom_build(self, env):
if (src_path / 'objs' / '.libs' / libfreetype).is_file():
return # Bail out because we have already built FreeType.

cc = get_ccompiler()

print(f"Building freetype in {src_path}")
if sys.platform != 'win32': # compilation on non-windows
env = {
**env,
"CC": (shlex.join(cc.compiler) if sys.version_info >= (3, 8)
else " ".join(shlex.quote(x) for x in cc.compiler)),
"CFLAGS": "{} -fPIC".format(env.get("CFLAGS", "")),
**{
var: value
for var, value in sysconfig.get_config_vars().items()
if var in {"CC", "CFLAGS", "CXX", "CXXFLAGS", "LD",
"LDFLAGS"}
},
}
subprocess.check_call(
["./configure", "--with-zlib=no", "--with-bzip2=no",
"--with-png=no", "--with-harfbuzz=no", "--enable-static",
"--disable-shared",
"--host=" + sysconfig.get_config_var('BUILD_GNU_TYPE')],
env=env, cwd=src_path)
env["CFLAGS"] = env.get("CFLAGS", "") + " -fPIC"
configure = [
"./configure", "--with-zlib=no", "--with-bzip2=no",
"--with-png=no", "--with-harfbuzz=no", "--enable-static",
"--disable-shared"
]
host = sysconfig.get_config_var('BUILD_GNU_TYPE')
if host is not None: # May be unset on PyPy.
configure.append(f"--host={host}")
subprocess.check_call(configure, env=env, cwd=src_path)
if 'GNUMAKE' in env:
make = env['GNUMAKE']
elif 'MAKE' in env:
Expand Down Expand Up @@ -668,6 +673,7 @@ def do_custom_build(self, env):
f.truncate()
f.write(vcxproj)

cc = get_ccompiler()
cc.initialize() # Get msbuild in the %PATH% of cc.spawn.
cc.spawn(["msbuild", str(sln_path),
"/t:Clean;Build",
Expand Down