Allow macosx thread safety test on macOS11 #21288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI setup definitely shows that it's the macOS 11 builders that fail, but I guess what I'm checking is not sufficient to differentiate. |
|
So the CI information says it's macOS 11.6, but |
It appears to no longer timeout on that system, and is breaking CI, which just switched to it. Note, macOS plays games with the version number it reports depending on how Python was compiled: https://eclecticlight.co/2020/08/13/macos-version-numbering-isnt-so-simple/
|
OK, apparently, macOS Big Sur reports both 10.16 and 11, depending on how Python might have been compiled. |
|
My fork is apparently still on macOS 10.15 and passed, while this repo used macOS 11, so this is working for both. |
greglucas
approved these changes
Oct 6, 2021
jklymak
approved these changes
Oct 6, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 6, 2021
timhoffm
added a commit
that referenced
this pull request
Oct 6, 2021
…288-on-v3.5.x Backport PR #21288 on branch v3.5.x (Allow macosx thread safety test on macOS11)
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 12, 2021
Allow macosx thread safety test on macOS11
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Allow macosx thread safety test on macOS11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
It appears to no longer timeout on that system, and is breaking CI, which just switched to it.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).