Skip to content

DOC: Bump to the sphinx-gallery release #21291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2021
Merged

DOC: Bump to the sphinx-gallery release #21291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,10 @@ dependencies:
- scipy
- sphinx>=1.8.1,!=2.0.0
- sphinx-copybutton
- sphinx-gallery>=0.10
- pip
- pip:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could put a cross-reference in the conda environment file so that only one location would be the source of truth.

Suggested change
- pip:
- pip:
- -r file:requirements/doc/doc-requirements.txt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I‘m somewhat sceptical on mixing conda and pip packages more than necessary. That could cause unnecessary dependency conflicts. If you think we need something better than manual syncing, please open an issue to discuss options.

- sphinxcontrib-svg2pdfconverter
# b41e328 is PR 808 which adds the image_srcset directive. When this is
# released with sphinx gallery, we can change to the last release w/o this feature:
# sphinx-gallery>0.9
- git+git://github.com/sphinx-gallery/sphinx-gallery@b41e328#egg=sphinx-gallery
- sphinxcontrib-svg2pdfconverter
# testing
- coverage
- flake8>=3.8
Expand Down
6 changes: 1 addition & 5 deletions requirements/doc/doc-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,7 @@ numpydoc>=0.8
packaging>=20
pydata-sphinx-theme>=0.6.0
sphinxcontrib-svg2pdfconverter>=1.1.0
# sphinx-gallery>=0.7
# b41e328 is PR 808 which adds the image_srcset directive. When this is
# released with sphinx gallery, we can change to the last release w/o this feature:
# sphinx-gallery>0.90
git+git://github.com/sphinx-gallery/sphinx-gallery@b41e328#egg=sphinx-gallery
sphinx-gallery>=0.10
sphinx-copybutton
sphinx-panels
scipy