Use in-tree builds for PyPy wheels #21307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing out-of-tree builds makes a copy that breaks symlinks in the git tree, causing PyPy wheels to get a version that signifies a dirty tree when they shouldn't. This will change in pip soon, but changing this will fix the version for our release now.
jklymak
approved these changes
Oct 7, 2021
dstansby
approved these changes
Oct 7, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 7, 2021
dstansby
added a commit
that referenced
this pull request
Oct 7, 2021
…307-on-v3.5.x Backport PR #21307 on branch v3.5.x (Use in-tree builds for PyPy wheels)
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 12, 2021
Use in-tree builds for PyPy wheels
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Use in-tree builds for PyPy wheels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Doing out-of-tree builds makes a copy that breaks symlinks in the git tree on Windows, causing PyPy wheels to get a version that signifies a dirty tree when they shouldn't.
This will change in pip soon, but changing this will fix the version for our release now.
Fixes #20929
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).