Skip to content

Fix default value for shading inpyplot.pcolormesh docstring #21332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Fix default value for shading inpyplot.pcolormesh docstring #21332

merged 2 commits into from
Oct 12, 2021

Conversation

navidcy
Copy link
Contributor

@navidcy navidcy commented Oct 10, 2021

PR Summary

Resolves #21314.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@navidcy navidcy changed the title fix default value for shading in docstring Fix default value for shading inpyplot.pcolormesh docstring Oct 10, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@navidcy navidcy requested a review from timhoffm October 12, 2021 03:54
@timhoffm timhoffm added this to the v3.5.0 milestone Oct 12, 2021
@timhoffm timhoffm merged commit 4546afd into matplotlib:master Oct 12, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 12, 2021
@timhoffm
Copy link
Member

Thanks @navidcy, and congratulations on your first contribution to Matplotlib! We hope to see you back.

jklymak added a commit that referenced this pull request Oct 12, 2021
…332-on-v3.5.x

Backport PR #21332 on branch v3.5.x (Fix default value for `shading` in`pyplot.pcolormesh` docstring)
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Oct 12, 2021
Fix default value for `shading` in`pyplot.pcolormesh` docstring
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
Fix default value for `shading` in`pyplot.pcolormesh` docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistensy in pyplot.pcolormesh docstring regarding default value for shading
2 participants