DOC: remove test from README.rst #21357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
Oct 14, 2021
|
Having this be the readme on pypi is also a choice we are making via: Line 280 in b2018cd we may want to differentiate between what shows up on GitHub and what shows up on pypi? |
|
Happy to do that instead. I didn't realize we could change it easily. However, I'm not sure that little section adds much to the github page either. |
timhoffm
approved these changes
Oct 14, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 14, 2021
QuLogic
added a commit
that referenced
this pull request
Oct 14, 2021
…357-on-v3.5.x Backport PR #21357 on branch v3.5.x (DOC: remove test from README.rst)
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
DOC: remove test from README.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The README shows up on pypi, and it tells everyone to run
pytestafter installing. I don't think most users should run pytest, and we already link to the contributing page below, where testing is covered in loving detail.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).