Convert macosx backend to use device_pixel_ratio #21365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A few other tests I should have mentioned (that should only need checking on a Retina display):
|
|
I just tested all of those cases and they all produce the expected output for me. These two PRs work well with the mixed DPI cases for me locally. |
This was not originally implemented in matplotlib#19126, but causes some inconsistencies with other backends. This also sets the initial scale as implemented in matplotlib#18274.
e7c5fe7 to
ab61cbe
Compare
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 20, 2021
6 tasks
QuLogic
added a commit
that referenced
this pull request
Oct 21, 2021
…365-on-v3.5.x Backport PR #21365 on branch v3.5.x (Convert macosx backend to use device_pixel_ratio)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This was not originally implemented in #19126, but causes some inconsistencies with other backends.
This also sets the initial scale as implemented in #18274.
I tested this out on MacStadium, but it only has a single display which isn't Retina. If you have a Retina display, you can check that the window is correctly double-sized.
If you have two displays, with mixed DPI, then you can check the full functionality. If you create a window on one display, and move it to the other, it should shrink/grow accordingly. A test I do is to start an interpreter, go to interactive mode, and open a figure on each display (on mutter, where your mouse is determines where a window first appears; I don't know if that's the same on macOS). Then you can drag one to the other display, and if resized correctly, they should match each other. Additionally, call
fig.set_size_inches(3, 3)on both while on different displays, and bringing them together should be the same size.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).