Skip to content

Enable tests for text path based markers #21377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2021
Merged

Enable tests for text path based markers #21377

merged 1 commit into from
Oct 18, 2021

Conversation

deep-jkl
Copy link
Contributor

@deep-jkl deep-jkl commented Oct 18, 2021 •
edited
Loading

PR Summary

This PR uncomments marker tests which required instances of TextPath. These tests were introduced (and unfortunately just commented out) in PR #20914, and can be used since #21280 is merged.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

anntzer
anntzer approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo CI.

@QuLogic QuLogic added this to the v3.6.0 milestone Oct 18, 2021
@QuLogic QuLogic merged commit 9568e14 into matplotlib:master Oct 18, 2021
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
@QuLogic
Merge pull request #21377 from deep-jkl/enable_text_marker_tests
92b208a 
Enable tests for text path based markers
@deep-jkl deep-jkl deleted the enable_text_marker_tests branch April 13, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@deep-jkl @QuLogic @anntzer