Hide fully transparent latex text in PS output #21470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This problem was fixed before for non-latex text. However, when using latex to render transparent text, it would still show up in PS output.
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
anntzer
approved these changes
Oct 27, 2021
jklymak
approved these changes
Oct 27, 2021
|
I don't see any reason to not back port this. |
|
Thanks @yschroeder ! |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 27, 2021
QuLogic
added a commit
that referenced
this pull request
Oct 27, 2021
…470-on-v3.5.x Backport PR #21470 on branch v3.5.x (Hide fully transparent latex text in PS output)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR closes #21466. It is a follow-up fix for #10166.
The PS backend initially rendered transparent text, which was not visible in other backends (e.g. PDF). #101166 fixed this for regular text but missed fixing this when using latex to render text. This PR fixes the problem for latex.
In #21466 @anntzer proposed to add a
@pytest.mark.parametrize()decorator totest_transparency(). However, I think duplicating the test is the better approach here, as we also need the@needs_usetexdecorator. this would result in the test not being run anymore when latex is missing which would be a step back.However, if you think it is fine that the test is only run when latex is installed, we can change to
@pytest.mark.parametrize(). I tried this already but had the additional problem that the test would be green regardless of the fix being applied (this is either me being stupid or@image_comparison()not working with additional decorators).PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).