Make _request_autoscale_view more generalizable to 3D. #21516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1331ee9 to
e4831cf
Compare
QuLogic
reviewed
Nov 3, 2021
Comment on lines
+3344
to
+3346
| for name in self._axis_names: | ||
| if axis in [name, "both"]: | ||
| loc = self._get_axis_map()[name].get_major_locator() |
There was a problem hiding this comment.
Can you join self._get_axis_map().items() as the loop iteration?
There was a problem hiding this comment.
You can, but you don't save a line, and giving a name to the second item of the tuple (the Axis) returned by _get_axis_map().items() is a bit awkward as axis is already the string there...
The API of _request_autoscale_view() was originally modelled to match the one of autoscale_view() -- hence the scalex/scaley/scalez kwargs -- but just taking an axis name (or "all") as single arg makes generalization to 3D easier. (In bxp(), the autoscale request does not need to be protected by checking whether the autoscale state is on, as autoscale_view is a noop for non-autoscaling axises.)
QuLogic
approved these changes
Nov 4, 2021
dstansby
reviewed
Dec 15, 2021
dstansby
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API of _request_autoscale_view() was originally modelled to
match the one of autoscale_view() -- hence the scalex/scaley/scalez
kwargs -- but just taking an axis name (or "all") as single arg makes
generalization to 3D easier.
(In bxp(), the autoscale request does not need to be protected by
checking whether the autoscale state is on, as autoscale_view is a noop
for non-autoscaling axises.)
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).